From bca875d67e9f4fad50bf47a6c9695687a6e95778 Mon Sep 17 00:00:00 2001 From: Jeremy Stanley Date: Thu, 6 Mar 2014 02:32:27 +0000 Subject: [PATCH] Wrap long lines without using backslashes Try to align more closely with Python style guidelines on wrapping long lines. --- lib/mudpy/misc.py | 95 ++++++++++++++++++++++++++--------------------------- lib/mudpy/telnet.py | 6 ++-- 2 files changed, 49 insertions(+), 52 deletions(-) diff --git a/lib/mudpy/misc.py b/lib/mudpy/misc.py index a8b0104..96957bc 100644 --- a/lib/mudpy/misc.py +++ b/lib/mudpy/misc.py @@ -623,8 +623,8 @@ class User: logline += self.account.get("name") else: logline += "an unknown user" - logline += " after idling too long in the " + \ - self.state + " state." + logline += (" after idling too long in the " + self.state + + " state.") log(logline, 2) self.state = "disconnecting" self.menu_seen = False @@ -788,8 +788,8 @@ class User: # with the optional eol string passed to this function # and the ansi escape to return to normal text if not just_prompt and prepend_padding: - if not self.output_queue \ - or not self.output_queue[-1].endswith(b"\r\n"): + if (not self.output_queue or not + self.output_queue[-1].endswith(b"\r\n")): output = "$(eol)" + output elif not self.output_queue[-1].endswith( b"\r\n\x1b[0m\r\n" @@ -1223,8 +1223,7 @@ def wrap_ansi_text(text, width): last_whitespace = abs_pos # insert an eol in place of the space - text = text[:last_whitespace] + \ - "\r\n" + text[last_whitespace + 1:] + text = text[:last_whitespace] + "\r\n" + text[last_whitespace + 1:] # increase the absolute position because an eol is two # characters but the space it replaced was only one @@ -2045,8 +2044,8 @@ def command_help(actor, parameters): else: output += " $(grn)" output += item + "$(nrm) - " + description + "$(eol)" - output += "$(eol)Enter \"help COMMAND\" for help on a command " \ - + "named \"COMMAND\"." + output += ("$(eol)Enter \"help COMMAND\" for help on a command " + "named \"COMMAND\".") # send the accumulated output to the user actor.send(output) @@ -2183,14 +2182,14 @@ def command_show(actor, parameters): status = "rw" else: status = "ro" - message += "$(eol) $(red)(" + status + ") $(grn)" + filename \ - + "$(nrm)" + message += ("$(eol) $(red)(" + status + ") $(grn)" + filename + + "$(nrm)") elif arguments[0] == "category": if len(arguments) != 2: message = "You must specify one category." elif arguments[1] in universe.categories: - message = "These are the elements in the \"" + arguments[1] \ - + "\" category:$(eol)" + message = ("These are the elements in the \"" + arguments[1] + + "\" category:$(eol)") elements = [ ( universe.categories[arguments[1]][x].key @@ -2205,8 +2204,8 @@ def command_show(actor, parameters): if len(arguments) != 2: message = "You must specify one file." elif arguments[1] in universe.files: - message = "These are the elements in the \"" + arguments[1] \ - + "\" file:$(eol)" + message = ("These are the elements in the \"" + arguments[1] + + "\" file:$(eol)") elements = universe.files[arguments[1]].data.sections() elements.sort() for element in elements: @@ -2218,15 +2217,14 @@ def command_show(actor, parameters): message = "You must specify one element." elif arguments[1] in universe.contents: element = universe.contents[arguments[1]] - message = "These are the properties of the \"" + arguments[1] \ - + \ - "\" element (in \"" + \ - element.origin.filename + "\"):$(eol)" + message = ("These are the properties of the \"" + arguments[1] + + "\" element (in \"" + element.origin.filename + + "\"):$(eol)") facets = element.facets() facets.sort() for facet in facets: - message += "$(eol) $(grn)" + facet + ": $(red)" \ - + escape_macros(element.get(facet)) + "$(nrm)" + message += ("$(eol) $(grn)" + facet + ": $(red)" + + escape_macros(element.get(facet)) + "$(nrm)") else: message = "Element \"" + arguments[1] + "\" does not exist." elif arguments[0] == "result": @@ -2265,8 +2263,8 @@ def command_show(actor, parameters): if level > -1 and start > -1 and stop > -1: message = get_loglines(level, start, stop) else: - message = "When specified, level must be 0-9 (default 1), " \ - + "start and stop must be >=1 (default 10 and 1)." + message = ("When specified, level must be 0-9 (default 1), " + "start and stop must be >=1 (default 10 and 1).") else: message = "I don't know what \"" + parameters + "\" is." actor.send(message) @@ -2287,18 +2285,18 @@ def command_create(actor, parameters): if element in universe.contents: message = "The \"" + element + "\" element already exists." else: - message = "You create \"" + \ - element + "\" within the universe." + message = ("You create \"" + + element + "\" within the universe.") logline = actor.owner.account.get( "name" ) + " created an element: " + element if filename: logline += " in file " + filename if filename not in universe.files: - message += " Warning: \"" + filename \ - + "\" is not yet included in any other file and will " \ - + \ - "not be read on startup unless this is remedied." + message += ( + " Warning: \"" + filename + "\" is not yet " + "included in any other file and will not be read " + "on startup unless this is remedied.") Element(element, universe, filename) log(logline, 6) elif len(arguments) > 2: @@ -2313,12 +2311,11 @@ def command_destroy(actor, parameters): message = "You must specify an element to destroy." else: if parameters not in universe.contents: - message = "The \"" + parameters + \ - "\" element does not exist." + message = "The \"" + parameters + "\" element does not exist." else: universe.contents[parameters].destroy() - message = "You destroy \"" + parameters \ - + "\" within the universe." + message = ("You destroy \"" + parameters + + "\" within the universe.") log( actor.owner.account.get( "name" @@ -2335,22 +2332,22 @@ def command_set(actor, parameters): else: arguments = parameters.split(" ", 2) if len(arguments) == 1: - message = "What facet of element \"" + arguments[0] \ - + "\" would you like to set?" + message = ("What facet of element \"" + arguments[0] + + "\" would you like to set?") elif len(arguments) == 2: - message = "What value would you like to set for the \"" \ - + arguments[1] + "\" facet of the \"" + arguments[0] \ - + "\" element?" + message = ("What value would you like to set for the \"" + + arguments[1] + "\" facet of the \"" + arguments[0] + + "\" element?") else: element, facet, value = arguments if element not in universe.contents: message = "The \"" + element + "\" element does not exist." else: universe.contents[element].set(facet, value) - message = "You have successfully (re)set the \"" + facet \ - + "\" facet of element \"" + element \ - + "\". Try \"show element " + \ - element + "\" for verification." + message = ("You have successfully (re)set the \"" + facet + + "\" facet of element \"" + element + + "\". Try \"show element " + + element + "\" for verification.") actor.send(message) @@ -2361,8 +2358,8 @@ def command_delete(actor, parameters): else: arguments = parameters.split(" ") if len(arguments) == 1: - message = "What facet of element \"" + arguments[0] \ - + "\" would you like to delete?" + message = ("What facet of element \"" + arguments[0] + + "\" would you like to delete?") elif len(arguments) != 2: message = "You may only specify an element and a facet." else: @@ -2370,14 +2367,14 @@ def command_delete(actor, parameters): if element not in universe.contents: message = "The \"" + element + "\" element does not exist." elif facet not in universe.contents[element].facets(): - message = "The \"" + element + "\" element has no \"" + facet \ - + "\" facet." + message = ("The \"" + element + "\" element has no \"" + facet + + "\" facet.") else: universe.contents[element].remove_facet(facet) - message = "You have successfully deleted the \"" + facet \ - + "\" facet of element \"" + element \ - + "\". Try \"show element " + \ - element + "\" for verification." + message = ("You have successfully deleted the \"" + facet + + "\" facet of element \"" + element + + "\". Try \"show element " + + element + "\" for verification.") actor.send(message) diff --git a/lib/mudpy/telnet.py b/lib/mudpy/telnet.py index a4264ce..dfac1ee 100644 --- a/lib/mudpy/telnet.py +++ b/lib/mudpy/telnet.py @@ -1,7 +1,7 @@ # -*- coding: utf-8 -*- """Telnet functions and constants for the mudpy engine.""" -# Copyright (c) 2004-2013 Jeremy Stanley . Permission +# Copyright (c) 2004-2014 Jeremy Stanley . Permission # to use, copy, modify, and distribute this software is granted under # terms provided in the LICENSE file distributed with this software. @@ -182,8 +182,8 @@ def negotiate_telnet_options(user): elif len_text > position + 4 and command is SB: telopt = ord(text[position + 2]) if telopt is TELOPT_NAWS: - user.columns = ord(text[position + 3]) * \ - 256 + ord(text[position + 4]) + user.columns = ( + ord(text[position + 3]) * 256 + ord(text[position + 4])) end_subnegotiation = text.find(telnet_proto(IAC, SE), position) if end_subnegotiation > 0: text = text[:position] + text[end_subnegotiation + 2:] -- 2.11.0